-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PublishDate does not roll-up to section, taxonomy, or term pages #12438
Comments
The version string was added to the generator tag in v0.125.0 to address #11692, and was removed in v0.125.3 to address #12300 (comment). We should have closed #11692 as "won't fix". I'll look into the zero pubdate problem. |
pubDate
values for categories/index.xml
and tags/index.xml
files
The I think the Applicable to:
This isn't something new (i.e., same behavior in v0.122.0). The test case below does not test for what should happen with publish dates greater than now() as described above. Failing testfunc TestFoo(t *testing.T) {
t.Parallel()
files := `
-- hugo.toml --
disableKinds = ['home','rss','sitemap']
[taxonomies]
tag = 'tags'
-- layouts/_default/list.html --
Date: {{ .Date.Format "2006-01-02" }}
PublishDate: {{ .PublishDate.Format "2006-01-02" }}
Lastmod: {{ .Lastmod.Format "2006-01-02" }}
-- layouts/_default/single.html --
{{ .Title }}
-- content/s1/p1.md --
---
title: p1
date: 2024-03-01
lastmod: 2024-03-02
tags: [t1]
---
-- content/s1/p2.md --
---
title: p2
date: 2024-04-03
lastmod: 2024-04-04
tags: [t1]
---
`
// Test without publishDate in front matter.
b := hugolib.Test(t, files)
b.AssertFileContent("public/s1/index.html", `
Date: 2024-04-03
PublishDate: 2024-04-03
Lastmod: 2024-04-04
`)
b.AssertFileContent("public/tags/index.html", `
Date: 2024-04-03
PublishDate: 2024-04-03
Lastmod: 2024-04-04
`)
b.AssertFileContent("public/tags/t1/index.html", `
Date: 2024-04-03
PublishDate: 2024-04-03
Lastmod: 2024-04-04
`)
// Test with publishDate in front matter.
files = strings.ReplaceAll(files, "lastmod", "publishDate")
b = hugolib.Test(t, files)
b.AssertFileContent("public/s1/index.html", `
Date: 2024-04-03
PublishDate: 2024-04-03
Lastmod: 2024-04-03
`)
b.AssertFileContent("public/tags/index.html", `
Date: 2024-04-03
PublishDate: 2024-04-03
Lastmod: 2024-04-03
`)
b.AssertFileContent("public/tags/t1/index.html", `
Date: 2024-04-03
PublishDate: 2024-04-03
Lastmod: 2024-04-03
`)
} |
Yea, that sounds reasonable. |
Is there a workaround that I could apply to get back the old behavior? Or is there a chance to revert to the old behavior until a working fix is found? |
Override the embedded RSS template, and change this line:
To:
If the page has a publication date, use that, else use the date. |
Add a custom `rss.xml` default layout with a workaround for a `PublishDate` regression for Hugo v0.125 and newer where the `PublishDate` does not get set correctly for all generated files. Details can be found here: gohugoio/hugo#12438 Hugo documentation: https://gohugo.io/templates/rss/#template-lookup-order The `rss.xml` file is based on the upstream default template found here: ``` curl -LO https://raw.githubusercontent.com/gohugoio/hugo/3d40aba512931031921463dafc172c0d124437b8/tpl/tplimpl/embedded/templates/_default/rss.xml ``` The changed line is: ``` <pubDate>{{ (or .PublishDate .Date).Format "Mon, 02 Jan 2006 15:04:05 -0700" | safeHTML }}</pubDate> ```
Thanks, that worked. For other readers: download the default rss.xml template to |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What version of Hugo are you using (
hugo version
)?Does this issue reproduce with the latest release?
Yes.
Description
After upgrading to v0.125 I see changes like the following for
categories/index.xml
andtags/index.xml
files:For subindex files like
categories/foo/index.xml
thepubDate
is set to the expected value, i.e. the generated output is identical to versions < v0.125.From looking at the changelog and commit f0a26cf58e9bfbe55c091d51a4133bc22cad5d1f it's not clear to me what needs to be changed in order to retain the previous (default) selection of values for
pubDate
? Am I missing something?Also, with above hugo version
{{ hugo.Version }}
doesn't seem to be set, resulting in the following output for thegenerator
tag:The text was updated successfully, but these errors were encountered: