opengraph template: CJK series meta tag malfunction #10647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything I should do to fix the CI checks? |
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 1, 2024
Changes: - Add tags per documentation - Prefer site.Title over site.Params.title - Plainify titles, tags, and descriptions - Add fallback values for locale - Fix pages related by series - Improve readability Closes gohugoio#8296 Closes gohugoio#8698 Closes gohugoio#8991 Closes gohugoio#9818 Closes gohugoio#9866 Closes gohugoio#10647 Co-authored by: tomy0000000 <git@tomy.me> Co-authored by: sean-au <sean@powerfulwebdesign.com.au>
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 1, 2024
Changes: - Add tags per documentation - Prefer site.Title over site.Params.title - Plainify titles, tags, and descriptions - Add fallback values for locale - Fix pages related by series - Improve readability Closes gohugoio#8296 Closes gohugoio#8698 Closes gohugoio#8991 Closes gohugoio#9818 Closes gohugoio#9866 Closes gohugoio#10647 Co-authored-by: tomy0000000 <git@tomy.me> Co-authored-by: sean-au <sean@powerfulwebdesign.com.au>
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 2, 2024
Changes: - Add tags per documentation - Prefer site.Title over site.Params.title - Plainify titles, tags, and descriptions - Add fallback values for locale - Fix pages related by series - Improve readability Closes gohugoio#8296 Closes gohugoio#8698 Closes gohugoio#8991 Closes gohugoio#9818 Closes gohugoio#9866 Closes gohugoio#10647 Co-authored-by: tomy0000000 <git@tomy.me> Co-authored-by: sean-au <sean@powerfulwebdesign.com.au>
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 2, 2024
Changes: - Add tags per documentation - Prefer site.Title over site.Params.title - Plainify titles, tags, and descriptions - Add fallback values for locale - Fix pages related by series - Improve readability Closes gohugoio#8296 Closes gohugoio#8698 Closes gohugoio#8991 Closes gohugoio#9818 Closes gohugoio#9866 Closes gohugoio#10647 Co-authored-by: tomy0000000 <git@tomy.me> Co-authored-by: sean-au <sean@powerfulwebdesign.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
opengraph.htmltemplate generate theog:see_alsometa tags, but it does not work when theseriesfront matter includes CJK characters. The root cause is that these characters are being url-encoded afterurlizefilter, while they're not in the.Site.Taxonomies.seriesmap.e.g.
Say I have a tag named
料理, afterurlizefilter, it becomes%E6%96%99%E7%90%86. Meanwhile, the.Site.Taxonomies.serieslooks a bit like:which is why it return no series page.
The ideal solution should be removing the
urlize, but the filter also sanitized other characters (e.g. emojis), so I fix the bug by using theurls.Parsefunction and then take thePathattribute, which is roughly URL decode the percentage encoded string back.