Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not warn on potentially unsafe HTML comments when unsafe=false #13288

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Do not warn on potentially unsafe HTML comments when unsafe=false #13288

merged 4 commits into from
Jan 22, 2025

Conversation

bep
Copy link
Member

@bep bep commented Jan 21, 2025

We will still not render these comments, so from a safety perspective this is the same, but HTML comments are very common also inside Markdown and too useful to throw away.

Updates #13278

@bep
Do not warn on potentially unsafe HTML comments when unsafe=false
e2bd987 
We will still not render these comments, so from a safety perspective this is the same, but HTML comments are very common also inside Markdown and too useful to throw away.

Updates gohugoio#13278
@bep bep requested a review from jmooring January 21, 2025 10:58
@jmooring
Copy link
Member

The blocks work great, but these emit warnings:

This is a <!--hidden--> word.

This is a <!-- hidden--> word.

This is a <!-- hidden --> word.

This is a <!-- 
hidden --> word.

This is a <!-- 
hidden
--> word.

@bep
Copy link
Member Author

bep commented Jan 21, 2025

Thanks, I forgot that we had 2 variants, pushed a fixed in 22145b5

jmooring
jmooring approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@jmooring jmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great. When released we should immediately deprecate the comment shortcode (emit warning). After a year or so throw an error. And probably keep that one-line shortcode for a few years.

@bep bep merged commit 9885e70 into gohugoio:master Jan 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmooring jmooring jmooring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bep @jmooring
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy