feat: Make MAX_DOWNLOADED_QUERY_RESULT_ROWS configurable #2167
+109
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- Add max_downloaded_rows field to BigQueryToolConfig with default value 50 - Add optional max_rows parameter to execute_sql function - Parameter takes precedence over config when both provided - Maintain backward compatibility with existing code - Add comprehensive tests for config and parameter functionality - Update truncation logic to use resolved max_downloaded_rows value
35fa798 to
9481f9b
Compare
- Create private constant _DEFAULT_MAX_DOWNLOADED_QUERY_RESULT_ROWS = 50 - Consolidate max_downloaded_rows logic to avoid duplication - Remove redundant None check in truncation logic
…:lupuletic/adk-python into feature/configurable-max-downloaded-rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code