Add missing project_id input #50
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Also no matter what I do I get a server error when trying to sign the CLA... not sure what's going on there. |
What error are you getting? |
b97b096 to
361a591
Compare
|
Well I tried again and it worked. Not sure what happened. |
|
Hi @aelawson - thanks for the PR! I added some additional commits that include addition of the new input parameter to the GitHub Actions config, and a unit test. Before merging I was wondering if you'd be willing/able to describe your use-case -- at a guess I imagine that you are authenticating to deploy with a service account in one project that has permissions to create Cloud Deploy releases in another, and so need to specify |
|
@henrybell while I am not the author of this PR, I can confirm that your description is exactly the use case I need this option for. |
|
Thanks @sergiosalvatore -- once merged, it'd be great if you could please let us know if there are any other outstanding features you're keen to see. Appreciate the input, and thanks again! |
## What's Changed * Update README and CI to use latest version by @sethvargo in #49 * Add missing project_id input by @aelawson in #50 * Update deps by @sethvargo in #51 ## New Contributors * @aelawson made their first contribution in #50 **Full Changelog**: v1.0.0...21fa1d2
This GitHub action is missing the common
project_idinput - I ran into this while trying to setup a deployment workflow on one of my repositories.I added the missing input and then updated the README to reflect it.