Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close default BulkWriter upon terminate. #2276

Merged
merged 3 commits into from
Jan 7, 2025
Merged

fix: close default BulkWriter upon terminate. #2276

merged 3 commits into from
Jan 7, 2025

Conversation

tom-andersen
Copy link
Contributor

Fixes #2273

@tom-andersen tom-andersen requested review from a team as code owners January 6, 2025 21:25
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jan 6, 2025
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2025
dconeybe
dconeybe approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-andersen tom-andersen merged commit 1e714a8 into main Jan 7, 2025
17 checks passed
@tom-andersen tom-andersen deleted the tomandersen/fixRecusiveDeleteClose branch January 7, 2025 15:41
@release-please release-please bot mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

db.terminate appears to detect BulkWriter leak from recursiveDelete
3 participants
@tom-andersen @dconeybe @yoshi-kokoro
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy