Fix URL path in mixed content samples #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I have signed Google Individual CLA agreement, please proceed. |
|
CLAs look good, thanks! |
Closed
johyphenel
suggested changes
Jul 2, 2017
| @@ -14,16 +14,16 @@ | |||
| <title>Active mixed content example</title> | |||
|
|
|||
| <!-- An insecure script file loaded on a secure page --> | |||
| <script src="http://googlesamples.github.io/web-fundamentals/samples/discovery-and-distribution/avoid-mixed-content/simple-example.js"></script> | |||
| <script src="http://googlesamples.github.io/web-fundamentals/samples/fundamentals/security/prevent-mixed-content/simple-example.js"></script> | |||
There was a problem hiding this comment.
I think "samples" needs to be removed from these URLs as well.
There was a problem hiding this comment.
Just realized how old this patch is :/
I can take over if you don't want to bother.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs broken in mixed content samples, I fixed it with a simple replacement, please merge this pull request.