Implement test for checking package-info inconsistencies #33643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskatos
reviewed
May 28, 2025
| tasks.register("packageInfoData", GeneratePackageInfoDataTask::class) { | ||
| description = "Map packages to the list of package-info.java files that apply to them" | ||
| outputFile = layout.projectDirectory.file("build/architecture/package-info.json") | ||
| packageInfoFiles = provider { GeneratePackageInfoDataTask.findPackageInfoFiles(projectBaseDirs) } |
There was a problem hiding this comment.
❌ Let's not have a script top-level scope projectBaseDirs variable populated far away from here but gather the list of project base dirs from architectureElements right here instead.
There was a problem hiding this comment.
I've tried that approach, but there are a lot of projects that are NOT included/linked to architectureElements. Maybe it's ok to ignore those projects (I have my doubts), but until we decide that, this solution is not viable.
18fb3d6 to
fbe283f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective.<subproject>/src/test) to verify logic../gradlew sanityCheck../gradlew <changed-subproject>:quickTest.Reviewing cheatsheet
Before merging the PR, comments starting with