Fix hb_buffer deserialization #5028
Conversation
IIUC this line intends to check that the last character closes the buffer array and != should be ==.
|
I'm not quite sure what the intention was :)). But the two other similar pieces of code do it slightly differently: harfbuzz/src/hb-buffer-deserialize-text-glyphs.rl Lines 138 to 148 in 6d8035a harfbuzz/src/hb-buffer-deserialize-text-unicode.rl Lines 117 to 126 in 6d8035a I wonder if we should do something similar here. |
|
What do those bits mean.. ignore whitespace until the closing delimiter? Not sure what the text-format deserialization looks like but I assume the '>' is some sort of array-like closing delimiter in the text format? |
I confess I'm not sure what that code does :)). I'll dig into it and report back.
Yes. The text format for Unicodes is like: |
IIUC this line intends to check that the last
character closes the buffer array and != should be ==.