github: Allow changelog check to be skipped on label #37314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanielMSchmidt I did think about that and concluded that the risk is relatively minimal, considering the audience is just our own team - not random people raising PRs - and also the existing label still comes up first in the completion box if you type I can add something like "DO NOT USE unless you know what you're doing" kind of warning into the description but regardless I think the risk is very minimal and the naming should make the difference relatively clear. |
DanielMSchmidt
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow cleanly merging PRs we raise every new minor version, such as #37312
The existing mechanism along with
no-changelog-neededworks for the common cases of regular functional PRs but not for these PRs where we are intentionally changing Changelog related files and at the same time changing nothing functionally.This would be unexpected situation under any other circumstance - and should continue to be raised by the checks outside of these PRs.
Target Release
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry