make hls speak websocket #4666
Draft
make hls speak websocket #4666
+1,674
−1,289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
This is the right thing to do because othewise it is not possible to create new ideStates in a single instance of the executable. This will be useful if the hls executable is supposed to talk to multiple clients and lives beyond a single client disconnecting.
Previously, when there was no shutdown message by a client and the client disconnected, resulting in the handlers to be GC'd the race that was supposed to free resources for the HieDB & co. would throw a hard error talking about the MVar being unreachable. We would like to instead finish gracefully because finishing the race as soon as the MVar was GC'd is the right thing to do anyway.
3dbefe0 to
bcddfda
Compare
|
Hey @soulomoon I would love to hear your opinion on a4ce2e8 which adds "syntactic" highlighting to the semantic tokens support... |
This is how it looks atm.
|
|
oh shoot. I might have messed up (need to split up that last commit in two) |
bcddfda to
a4ce2e8
Compare
|
Good job, look promising @MangoIV |
|
@soulomoon yes I will have to, thank you :) |
Use the GHC AST and lsp semantic tokens to convince the language server to give highlighting even without any editor highlighting plugins.
a4ce2e8 to
e260ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try it out in combination with https://github.com/MangoIV/hls-playground by running that with
npm run devand this withcabal run -f-cabal -f-dynamic exe:haskell-language-server -- -d ws