Skip to content

fix(fuse): potential panic on unknown mode bits #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

mkroening
Copy link
Member

There has been a panic here at least once: https://github.com/hermit-os/kernel/actions/runs/9357240494/job/25756534015?pr=1248#step:25:195

$ cargo xtask ci qemu --arch x86_64 --profile release --package rftrace-example --virtiofsd
...
Saving traces to disk...!
0xc1b000, Events { ptr: 0xc1b000, len: 2000, cap: 2000 }
  Parsing TID 1...!
  Writing to disk: 8 events, 128 bytes (/root/tracedir/1.dat)
  Parsed all events!
Creating fake uftrace data dir at /root/tracedir..
  Creating ./info
    feats = TASK_SESSION | SYM_REL_ADDR
    info = CMDLINE | TASKINFO
    cmdline = 'fakeuftrace'
    tid = [1]
  Creating ./task.txt
[0][PANIC] panicked at src/fs/fuse.rs:479:47:
called `Result::unwrap()` on an `Err` value: TryFromIntError(())

Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
@mkroening
Copy link
Member Author

@stlankes, should we retain or truncate unknown bits in file attribute mode?

@stlankes stlankes added this pull request to the merge queue Jun 5, 2024
@stlankes
Copy link
Contributor

stlankes commented Jun 5, 2024

Retain...

Merged via the queue into main with commit 9881cfb Jun 5, 2024
13 checks passed
@mkroening mkroening deleted the mode-panic branch June 5, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy