HSEARCH-5356 Introduce the extended (platform) BOM #4712
+1,967
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e929ac to
5f4284a
Compare
|
hey @yrodiere 🙂 👋🏻 if you have the time ... I'd like your opinion on what's included in these platform poms 🫣 🙂 |
yrodiere
reviewed
Jul 23, 2025
...org/hibernate/search/build/enforcer/DependencyManagementIncludesAllGroupIdArtifactsRule.java
Show resolved
Hide resolved
documentation/src/main/asciidoc/public/reference/_compatibility.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/public/reference/_compatibility.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/public/reference/_compatibility.adoc
Outdated
Show resolved
Hide resolved
5f4284a to
ef88840
Compare
yrodiere
reviewed
Jul 23, 2025
b51821a to
faec9f4
Compare
yrodiere
reviewed
Jul 25, 2025
bom/platform-next/pom.xml
Outdated
Comment on lines
44
to
47
| <!-- | ||
| Hibernate Search artifacts listed explicitly as we cannot exclude some from the bom import, | ||
| and we want to skip the lucene-next ones for this pom to not mix different Lucene versions | ||
| --> |
There was a problem hiding this comment.
Makes me think you probably need a hibernate-search-next-bom too?
There was a problem hiding this comment.
This one seems to work unexpectedly ok 😃
Since it does not manage Lucene directly each backend transitevely brings the version it wants as long as you do not use two lucene backends at the same time 😃
bom/platform-next/pom.xml
Outdated
Comment on lines
140
to
200
| <version>${version.bom.org.jberet}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jberet</groupId> | ||
| <artifactId>jberet-se</artifactId> | ||
| <version>${version.bom.org.jberet}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jberet</groupId> | ||
| <artifactId>test-deployment</artifactId> | ||
| <version>${version.bom.org.jberet}</version> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>archetype-lambda</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>aws-sdk-java</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>bundle-logging-bridge</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>bundle-sdk</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>bundle</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>core</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>crt-core</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>http-clients</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>metric-publishers</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>protocols</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>ruleset-testing-core</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>service-test-utils</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>services-custom</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>services</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>test-utils</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>third-party-slf4j-api</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>third-party</artifactId> | ||
| <version>${version.bom.software.amazon.awssdk}</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </dependencyManagement> |
There was a problem hiding this comment.
Would it make sense to avoid repetition by either:
- Importing the normal BOM and overriding just lucene dependencies? But then you'd be managing
hibernate-search-backend-lucene(not next) even though it can't work with the managed version of Lucene. - Importing a separate POM dedicated to just dependencies, not Hibernate Search artifacts, in both platform poms, and overriding the Lucene version here?
There was a problem hiding this comment.
Importing a separate POM dedicated to just dependencies, not Hibernate Search artifacts, in both platform poms, and overriding the Lucene version here?
this one would be nice yeah ... but I guess if we'd make some bom/platform-common we'd need to either publish it as well ... or don't publish but inline all the dependencies...
let me pull the common part and see if it would look better that way, and if so -- I'll just inline the dependencies, after all ... it is to manage dependencies and not to be read by a human on a daily basis 😁 🙈
faec9f4 to
3f82c22
Compare
3f82c22 to
0e302bd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-5356
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.