Add HTML5 notification service translations #148582
Draft
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing translation strings for the HTML5 notification service in the UI. The HTML5 'Send a notification with html5' action now displays properly localized strings for the service name, description, and field names (message, title, target, data). This resolves the issue where the HTML5 notification service appeared without translations in the Home Assistant UI automation editor. Fixes home-assistant#129359
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @alexyao2015, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
NoRi2909
reviewed
Jul 11, 2025
Comment on lines
+31
to
+32
| "name": "Send a notification with html5", | ||
| "description": "Sends a notification message using the html5 service.", |
There was a problem hiding this comment.
We should keep the action name short, consistent with "Dismiss"
Also we usually capitalize all abbreviations (I will fix the other action description, too)
Suggested change
| "name": "Send a notification with html5", | |
| "description": "Sends a notification message using the html5 service.", | |
| "name": "Notify", | |
| "description": "Sends a notification message using the HTML5 service.", |
Also makes it consistent with the description for the "data" field.
| }, | ||
| "title": { | ||
| "name": "Title", | ||
| "description": "The title of the message (optional)." |
There was a problem hiding this comment.
In the UI an optional field has a check box next to it so we don't need to add that to the description.
Also the data field is optional as well – IIRC.
Suggested change
| "description": "The title of the message (optional)." | |
| "description": "The title of the message." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the missing translation strings for the HTML5 notification service in the Home Assistant UI.
Changes Made
homeassistant/components/html5/strings.jsonmessage,title,target, anddatafieldsProblem Solved
Previously, when users tried to use the "Send a notification with html5" action in the Home Assistant UI, the service would appear without proper translations, showing raw technical strings instead of user-friendly localized text.
Testing
strings.jsonis valid JSONScreenshots
Before this fix, the HTML5 notification service displayed untranslated strings in the UI automation editor. After this fix, users will see properly localized strings for the service name, description, and all field names.
Fixes #129359