Skip to content

Add Demo Vacuum in entity name #148629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Add Demo Vacuum in entity name #148629

wants to merge 3 commits into from

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Jul 11, 2025 •
edited
Loading

Proposed change

Add Demo vacuum in entity name. They are easier to find by searching for the keyword.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (demo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of demo can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign demo Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@lboue lboue marked this pull request as ready for review July 11, 2025 22:48
@lboue lboue requested a review from a team as a code owner July 11, 2025 22:48
MartinHjelmare
MartinHjelmare requested changes Jul 12, 2025
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft July 12, 2025 09:41
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@MartinHjelmare
Copy link
Member

Tests need to be updated. How did the tests pass locally?

@lboue
Copy link
Contributor Author

lboue commented Jul 12, 2025

Tests need to be updated. How did the tests pass locally?

Fixed now.

@MartinHjelmare
Copy link
Member

How did the tests pass locally?

@lboue
Copy link
Contributor Author

lboue commented Jul 12, 2025

Now a test is failing because of voip components. So not related to this PR:

--------------------------- snapshot report summary ----------------------------
1554 snapshots passed. 1 snapshot unused.

Unused test_calls_not_allowed (tests/components/voip/snapshots/test_voip.ambr)
Re-run pytest with --snapshot-update to delete unused snapshots.
============================= slowest 10 durations =============================
8.79s call     tests/components/voip/test_voip.py::test_calls_not_allowed
3.75s call     tests/components/stream/test_ll_hls.py::test_ll_hls_stream
3.72s call     tests/components/voip/test_voip.py::test_start_conversation
2.39s call     tests/components/recorder/test_statistics_v23_migration.py::test_delete_duplicates_many[True]
2.26s call     tests/components/stream/test_worker.py::test_h265_video_is_hvc1
1.52s call     tests/components/voip/test_voip.py::test_tts_wrong_wav_format
1.34s call     tests/components/recorder/test_migration_from_schema_32.py::test_migrate_null_event_type_ids[True-True]
1.28s call     tests/components/recorder/test_migration_from_schema_32.py::test_migrate_null_entity_ids[True-True]
1.28s call     tests/components/recorder/auto_repairs/statistics/test_duplicates.py::test_delete_metadata_duplicates_many[True]
1.12s call     tests/components/voip/test_voip.py::test_tts_wrong_extension
=========================== short test summary info ============================
FAILED tests/components/voip/test_voip.py::test_calls_not_allowed - Failed: Timeout (>9.0s) from pytest-timeout.

@MartinHjelmare
Copy link
Member

Right. You had checked the check box that tests passed locally before updating the related tests. I was wondering how they could have passed before you did that.

@lboue
Copy link
Contributor Author

lboue commented Jul 12, 2025 •
edited
Loading

Right. You had checked the check box that tests passed locally before updating the related tests. I was wondering how they could have passed before you did that.

Yes my mistake.
Do you know how to fix the timeout issue? It works locally for voip but it takes 41s (more that 15s timeout):

pytest tests/components/voip/test_voip.py --snapshot-update
Test session starts (platform: linux, Python 3.13.3, pytest 8.4.0, pytest-sugar 1.0.0)
rootdir: /home/ludovic/ha_core
configfile: pyproject.toml
plugins: aiohttp-1.1.0, respx-0.22.0, anyio-4.9.0, syrupy-4.9.1, xdist-3.7.0, timeout-2.4.0, requests-mock-1.12.1, unordered-0.7.0, socket-0.7.0, cov-6.1.1, pytest_freezer-0.4.9, github-actions-annotate-failures-0.3.0, picked-0.5.1, sugar-1.0.0, asyncio-1.0.0
asyncio: mode=Mode.AUTO, asyncio_default_fixture_loop_scope=function, asyncio_default_test_loop_scope=function
collected 16 items

 tests/components/voip/test_voip.py ✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓                                                                                                                          100% ██████████
---------------------------------------------------------------------------------- snapshot report summary ----------------------------------------------------------------------------------
2 snapshots passed.

Results (41.68s):
      16 passed

@MartinHjelmare
Copy link
Member

No, I don't know why the voip test fails. I don't think we need to solve that here.

@lboue lboue marked this pull request as ready for review July 12, 2025 14:24
@home-assistant home-assistant bot requested a review from MartinHjelmare July 12, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare Awaiting requested review from MartinHjelmare

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cla-signed code-quality core integration: demo Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lboue @MartinHjelmare
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy