-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Deprecating the Forecast sensor, adding note about new action #39072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Deprecating the Forecast sensor, adding note about new action #39072
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe documentation for the Amber Electric integration was updated to deprecate the existing "Forecast" sensor, announcing its removal in version 2025.11. Users are now instructed to use the new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AmberElectric Integration
User->>AmberElectric Integration: Call get_forecasts(site_id, channel_type)
AmberElectric Integration-->>User: Return array of forecast data for specified channel
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/amberelectric.markdown (1)
64-64
: Add trailing newline
Markdown files should end with a single newline character to satisfy MD047 (single-trailing-newline).🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
64-64: Files should end with a single newline character
null(MD047, single-trailing-newline)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/amberelectric.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/amberelectric.markdown
[uncategorized] ~62-~62: A punctuation mark might be missing here.
Context: ...--------------------------------------- | | site_id
| Yes | ID of the...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/amberelectric.markdown
64-64: Files should end with a single newline character
null
(MD047, single-trailing-newline)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/amberelectric.markdown (2)
47-47
: Deprecate Forecast sensor and guide users to use the new action
The deprecation note is clear and specifies the removal version (2025.11). It correctly instructs users to switch to theget_forecasts
action.
55-64
: Document newget_forecasts
action
The new Actions section andget_forecasts
action table accurately describe the endpoint and optional parameters (site_id
,channel_type
). Please verify that these attribute names and descriptions align with the implementation in core PR #144848 to ensure consistency.🧰 Tools
🪛 LanguageTool
[uncategorized] ~62-~62: A punctuation mark might be missing here.
Context: ...--------------------------------------- | |site_id
| Yes | ID of the...(AI_EN_LECTOR_MISSING_PUNCTUATION)
🪛 markdownlint-cli2 (0.17.2)
64-64: Files should end with a single newline character
null(MD047, single-trailing-newline)
Add newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
source/_integrations/amberelectric.markdown (1)
61-65
:⚠️ Potential issueFix typo in
channel_type
optionThe table lists
controller_load
, but the channel type is named “Controlled Load” elsewhere. Update the option to avoid confusion:-| `channel_type` | Yes | The channel type to fetch. Options: general, controller_load, feed_in | +| `channel_type` | Yes | The channel type to fetch. Options: general, controlled_load, feed_in |🧰 Tools
🪛 LanguageTool
[uncategorized] ~62-~62: A punctuation mark might be missing here.
Context: ...--------------------------------------- | |site_id
| Yes | ID of the...(AI_EN_LECTOR_MISSING_PUNCTUATION)
🧹 Nitpick comments (1)
source/_integrations/amberelectric.markdown (1)
55-59
: Add aversionadded
directive for the new actionTo help users understand when this feature was introduced, consider adding a version directive immediately before the action:
+:::versionadded 2025.11 +Introduced the `get_forecasts` action, replacing the deprecated Forecast sensor. +::: ### `get_forecasts`
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/amberelectric.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/amberelectric.markdown
[uncategorized] ~62-~62: A punctuation mark might be missing here.
Context: ...--------------------------------------- | | site_id
| Yes | ID of the...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
source/_integrations/amberelectric.markdown (1)
50-52
: Deprecation admonition implemented correctly
Great use of a dedicated deprecation block for the Forecast sensor, making the impending removal in version 2025.11 and the migration path toget_forecasts
unmissable.
🧹 Nitpick comments (1)
source/_integrations/amberelectric.markdown (1)
65-68
: Punctuation consistency in the parameter table
Add a trailing period to thechannel_type
description for consistency with thesite_id
row:- | `channel_type` | Yes | The channel type to fetch. Options: general, controller_load, feed_in | + | `channel_type` | Yes | The channel type to fetch. Options: general, controller_load, feed_in. |🧰 Tools
🪛 LanguageTool
[uncategorized] ~66-~66: A punctuation mark might be missing here.
Context: ...--------------------------------------- | |site_id
| Yes | ID of the...(AI_EN_LECTOR_MISSING_PUNCTUATION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/amberelectric.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/amberelectric.markdown
[uncategorized] ~66-~66: A punctuation mark might be missing here.
Context: ...--------------------------------------- | | site_id
| Yes | ID of the...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
🔇 Additional comments (1)
source/_integrations/amberelectric.markdown (1)
59-63
: Well-structured Actions section forget_forecasts
The new "Actions" section with clear headings and concise description aligns with Home Assistant's documentation style and guides users to the new functionality effectively.
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
get_forecasts
action for retrieving forecast data, supporting optional parameters for site and channel type.