Skip to content

beta -> latest #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 4, 2023
Merged

beta -> latest #3467

merged 9 commits into from
Nov 4, 2023

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Oct 29, 2023 •
edited
Loading

⚠️ we will need to make clear in the release notes that any version of node that is not 18 nor 20 is not supported

♻️ Current situation

A lot of dependencies are out of date.

💡 Proposed solution

Update them :)

⚙️ Release Notes

  • Minimum supported node version is now 18, officially v18 and v20 are supported
  • Updated dependencies

➕ Additional Information

Node 18 really is the least supported version now, as changes in the package json engines

Testing

No tests were changed, but all are still passing

donavanbecker and others added 5 commits October 28, 2023 01:51
@donavanbecker
workflow to .github latest branch
6fb24c9
@donavanbecker
Update CHANGELOG.md
ea4cf26
@bwp91 @donavanbecker
update patch/minor dependencies (#3459)
986e655 
* branch `master` to `latest` (#3439)

* update workflow to .github's branch latest

* patch/minor dep updates

* some major dep updates (#3460)

---------

Co-authored-by: Donavan Becker <beckersmarthome@icloud.com>
@bwp91
update changelog
3a4ab91
@bwp91
Merge branch 'latest' into beta
a25b2c4
@coveralls
Copy link

coveralls commented Oct 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6752847955

  • 1 of 5 (20.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 25.803%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ipcService.ts 1 2 50.0%
src/childBridgeService.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/ipcService.ts 1 74.07%
Totals Coverage Status
Change from base Build 6675469578: -0.2%
Covered Lines: 392
Relevant Lines: 1365
💛 - Coveralls

@bwp91 bwp91 requested a review from bauer-andreas November 1, 2023 21:15
@bwp91 bwp91 marked this pull request as ready for review November 1, 2023 21:16
@bwp91 bwp91 requested a review from NorthernMan54 November 1, 2023 21:17
@bwp91 bwp91 mentioned this pull request Nov 1, 2023
Closed
bauer-andreas
bauer-andreas previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@bauer-andreas bauer-andreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work 🚀

@bwp91
Copy link
Contributor Author

bwp91 commented Nov 1, 2023

@Supereg this check

build_and_test / build (16) Expected — Waiting for status to be reported

I can't see where it comes from ?

@bauer-andreas
Copy link
Member

@Supereg this check

build_and_test / build (16) Expected — Waiting for status to be reported

I can't see where it comes from ?

It's still configured as a required check in the branch protection rules. So it shows up as required (but isn't scheduled as it doesn't exist anymore). I'll remove it real quick.

@donavanbecker
v1.7.0
a1ca575 
## v1.7.0 (2023-11-04)

### Other Changes

- Update dependencies by @bwp91 in #3459 and #3460
@donavanbecker donavanbecker enabled auto-merge (squash) November 4, 2023 04:53
@donavanbecker donavanbecker merged commit 50f9154 into latest Nov 4, 2023
@donavanbecker donavanbecker deleted the beta-1.7.0 branch November 4, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donavanbecker donavanbecker donavanbecker approved these changes

@bauer-andreas bauer-andreas bauer-andreas left review comments

@NorthernMan54 NorthernMan54 Awaiting requested review from NorthernMan54

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bwp91 @coveralls @bauer-andreas @donavanbecker
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy