Skip to content

v1.11.0-beta #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2025
Merged

v1.11.0-beta #3827

merged 3 commits into from
Jul 13, 2025

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Jul 13, 2025

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for including an optional port in child bridge metadata and updates development dependencies.

  • Extend ChildMetadata to include an optional port field.
  • Populate port when building the metadata payload.
  • Bump versions of several devDependencies in package.json.

Reviewed Changes

Copilot reviewed 38 out of 41 changed files in this pull request and generated no comments.

File Description
src/childBridgeService.ts Added port?: number to the interface and populate it
package.json Updated devDependency versions (Jest, TypeScript tools)
docs/... Regenerated documentation to reflect the new field
Comments suppressed due to low confidence (3)

src/childBridgeService.ts:117

  • Add a JSDoc comment describing the port field in ChildMetadata so that consumers know what it represents and when it should be used.
  port?: number;

src/childBridgeService.ts:510

  • [nitpick] Consider adding fallback logic or default behavior when bridgeConfig.port is undefined to avoid potential consumer errors if this field is not set.
      port: this.bridgeConfig.port,

src/childBridgeService.ts:507

  • Add or update unit tests to verify that the port field is correctly included in the metadata output when bridgeConfig.port is provided.
      paired: this.pairedStatus,

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16251469062

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 27.397%

Totals Coverage Status
Change from base Build 15506056870: -1.0%
Covered Lines: 431
Relevant Lines: 1376

💛 - Coveralls

@bwp91 bwp91 merged commit b91a4b1 into latest Jul 13, 2025
18 checks passed
@bwp91 bwp91 deleted the beta-1.11.0 branch July 13, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy