Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.8 #285

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Release 1.1.8 #285

merged 2 commits into from
Sep 12, 2022

Conversation

MoojMidge
Copy link
Collaborator

Update addon.xml and README.md

@MoojMidge MoojMidge merged commit 9a82918 into im85288:master Sep 12, 2022
@im85288
Copy link
Owner

im85288 commented Sep 12, 2022

@MoojMidge thanks for releasing a new version. Looks like the matrix version went in correctly however the leia version failed with:

"ERROR: service.upnext addon already exists with a lower or equal version: 1.1.5+matrix.1 in nexus branch and the addon has non forward abi compatible dependencies. Users migrating to kodi version nexus won't be able to receive the addon update.
11
ERROR: service.upnext addon already exists with a lower or equal version: 1.1.5+matrix.1 in matrix branch and the addon has non forward abi compatible dependencies. Users migrating to kodi version matrix won't be able to receive the addon update."

Not sure where it got that 1.1.5+matrix.1 version when its target is leia! Anyway maybe we can drop support for leia as most users will be using matrix now.

Here is the link in case you had not seen it: https://github.com/xbmc/repo-scripts/actions/runs/3039547548/jobs/4894594249

@MoojMidge
Copy link
Collaborator Author

Got there in the end :)

I think the error is not a big deal. It's basically saying that the current version in the matrix/nexus repository (1.1.5+matrix.1) has a lower version number than the version in the leia PR (1.1.8), so someone trying to upgrade Kodi from leia to matrix/nexus won't be able to update the addon and will get a python 2 dependency error.

Once the PR is accepted to the matrix/nexus repository, then the addon-checker should also work for the leia PR because the new version in the matrix/nexus repository (1.1.8+matrix.1) should be higher.

Up to you about leia support, aside from f-strings I don't think there is any major downside to the current backwards compatibility, but I'm not sure what changes nexus requires.

@MoojMidge MoojMidge deleted the release-1.1.8 branch September 12, 2022 18:48
@im85288
Copy link
Owner

im85288 commented Sep 12, 2022

Awesome, yeah I wasn't even aware the next version was called nexus. I guess it would be better to assure the addon runs on nexus rather than worry about leia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy