feat(inputs.procstat): Add child level tag #16105
Conversation
There was a problem hiding this comment.
Thanks for the PR! I have one code question, but also does this close issue #16104? If so could you update the PR description to close the issue? Thanks!
Yes it's the same. The issue is in the PR description. What do you understand exactly by :
|
|
@tguenneguez the error means that the You need to add the option documentation to |
Thank you very much, I don't know how you found the cause, if you can tell me I will be more independent next time ;-) |
|
I understand my error ;-) So I thing it will be great to have possibility to generate "procstat_lookup" for different level... |
There was a problem hiding this comment.
@tguenneguez thanks for the update. I do have some comments. The most important one is to only add the child_level tag if the option is actually set. The code adds it unconditionally still.
|
Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you! |
@srebhan ask me to remove space : #16105 (review) What must I do ? |
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
|
No, he asked to revert. (Not in these exact words) |
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
|
Great, now it looks only a |
There was a problem hiding this comment.
@tguenneguez thanks for the update and sorry for not being clear on the intend! I have one question and a request. The request is to also add a metric for level zero i.e. the uppermost processes returned!
The question is about also adding the level tag to the actual procstat process metrics. What do you think?
No problem
I don't see where is the problem
|
I think I missed the fact that in line 183 of
What I mean is also adding the To fix the CircleCI issues, please run |
|
I try to run
|
|
@tguenneguez do you run golang v1.24? I pushed the format corrections for you... |
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -1.08 % for linux amd64 (new size: 288.7 MB, nightly size 291.8 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
|
@DStrand1 I will assign this back to you for giving it a final check as the code changed quite a bit... |
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Summary
Add tag for children process to be able to have information by level
Checklist
Related issues
resolves #16104