Skip to content

Make using tests.sh for JS SDK and Golang SDK tests easier #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

albertchae
Copy link
Contributor

@albertchae albertchae commented Jul 10, 2025

Description

Improve tests.sh (used for local dev testing only)

mostly done with claude

  • kill existing dev server processes to avoid conflict
  • wait for dev server healthcheck before continuing rest of tests
  • optionally take TEST_PATTERN which will pass that to both the JS/SDK
    test suites to narrow tests, e.g. ./tests.sh TestEventList
  • cleanup background processes when script exits (either normally or
    gets interrupted)
  • use --frozen-lockfile to match CI behavior

As mentioned in slack, this script is not currently used by CI, so we
might eventually think about unifying them
https://github.com/inngest/inngest/blob/main/.github/workflows/e2e.yml

Motivation

It is hard to iterate on these tests locally because they have to coordinate with a running dev server process

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

Copy link

vercel bot commented Jul 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2025 10:26pm

@albertchae albertchae marked this pull request as ready for review July 10, 2025 19:33
@albertchae albertchae enabled auto-merge (squash) July 10, 2025 19:34
mostly done with claude
- kill existing dev server processes to avoid conflict
- wait for dev server healthcheck before continuing rest of tests
- optionally take TEST_PATTERN which will pass that to both the JS/SDK
  test suites to narrow tests
- cleanup background processes when script exits (either normally or
  gets interrupted)
- use --frozen-lockfile to match CI behavior

As mentioned in slack, this script is not currently used by CI, so we
might eventually think about unifying them
https://github.com/inngest/inngest/blob/main/.github/workflows/e2e.yml
@albertchae albertchae merged commit b2d64db into main Jul 22, 2025
39 of 42 checks passed
@albertchae albertchae deleted the improve-tests.sh branch July 22, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy