Skip to content

chore: replaced $npm_config_watch for npm v11 #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

chore: replaced $npm_config_watch for npm v11 #1729

merged 1 commit into from
May 14, 2025

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented May 9, 2025

@kirrg001 kirrg001 requested a review from a team as a code owner May 9, 2025 14:20
@abhilash-sivan
Copy link
Contributor

suggestion:

The commit message is a bit confusing - we're actually reducing warn logs by adopting the new -- syntax.

aryamohanan
aryamohanan reviewed May 14, 2025
View reviewed changes
Copy link
Contributor

@aryamohanan aryamohanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current commit message is a bit unclear. Consider something like:

chore: updated watch mode configuration to eliminate warnings in npm v11

or something similiar

aryamohanan
aryamohanan reviewed May 14, 2025
View reviewed changes
Copy link
Contributor

@aryamohanan aryamohanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qs: Should we update this as well? Currently, we're checking for --watch, so there won't be any warnings (see), but it might be good to update this for consistency if needed.

@kirrg001
Copy link
Contributor Author

qs: Should we update this as well? Currently, we're checking for --watch, so there won't be any warnings (see), but it might be good to update this for consistency if needed.

No this is the input argument for our test script.

@kirrg001 kirrg001 merged commit be90513 into main May 14, 2025
1 check was pending
@instanacd instanacd deleted the chore-npmv11 branch July 14, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhilash-sivan abhilash-sivan abhilash-sivan approved these changes

@aryamohanan aryamohanan aryamohanan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirrg001 @abhilash-sivan @aryamohanan
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy