fix: command lookup error when scope is cached #1716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed lookup to use .get() on the dictionary to prevent large log of error in the circumstance of a cache command showing on a changed scope Signed-off-by: Sondra <125593620+sondevra@users.noreply.github.com>
|
@AstreaTSS need your help adding reviewers. |
|
Reviewers don't need to be manually added - the contributors of interactions.py will see this and review whenever they can on their own. |
AstreaTSS
reviewed
Jul 13, 2024
Signed-off-by: Sondra <125593620+sondevra@users.noreply.github.com>
AstreaTSS
approved these changes
Jul 18, 2024
silasary
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed lookup to use .get() on the dictionary to prevent large log of error in the circumstance of a cache command showing on a changed scope
Pull Request Type
Description
Fixed lookup to use .get() on the dictionary to prevent large log of error in the circumstance of a cache command showing on a changed scope.
What happens is when no commands have been loaded to a Discord guild's scope, but they are cached, if a user tries to request one of these cached commands, an error occurs because of the way the lookup was handled (index notation)
Changes
.get()on the dictionary.Related Issues
Test Scenarios
Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files