[JENKINS-33808] Support for Item categorization #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
|
Changes look good. Retriggering the build. |
|
Tests running fine locally, let's get this merged and I will investigate the test timeout separately 🐝 |
|
Tested live locally (after building the upstream locally also). Not merging until |
|
🐝 |
|
@amuniz |
amuniz
pushed a commit
that referenced
this pull request
Apr 25, 2018
Added simple test for the TagDiscoveryTrait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-33808
downstream of jenkinsci/scm-api-plugin#9
@reviewbybees especially @jglick
Screenshot