Build: Move ESLint max-len disable-directive to dist/.eslintrc.json #4676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disable-directive only applies to the built version, so put it in /dist. This avoids a warning about an unused directive in the source version. Follow-up to jquery#4520
mgol
approved these changes
Apr 21, 2020
|
@edg2s I edited the PR title, we only use a fixed number of components as defined in Our commit guidelines are docummented at: |
|
As a follow up to this I will submit 2882f19 that will allow us to set max warnings to 0 in grunt-eslint. |
timmywil
approved these changes
Apr 27, 2020
mgol
reviewed
Apr 27, 2020
|
Landed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disable-directive only applies to the built version, so put it in /dist. This avoids a warning about an unused directive in the source version.
Follow-up to #4520
Checklist