Core: removed aria-required attribute #2012
Conversation
|
@alexbokii |
|
@Arkni No, it's different when we use divs - we need to apply aria-required attribute if the div tag is used instead of the input tag and user input is required. But the div should have a role attribute that points to the nature of control - it can be a "textbox", "combobox", etc. |
|
IIRC we support only real input types. When people use custom markup instead of native input elements they should apply the aria roles for them. IMHO we should stop adding aria attributes. 👍 |
There was a problem hiding this comment.
Given the fact that this PR is a bug fix, there is nothing to fear from a semver perspective.
I'm going to merge this for now, and if someone complain about contenteditable, we will then consider adding an aria-required attribute to it only in case the role textbox is present.
|
@alexbokii |
|
@Arkni happy to help :) |
According to the latest documentation, 'aria-required' is a widget attribute and should be used only with particular roles. We don’t need to use it with native elements and when ‘required’ attribute exist. At the moment all instances of 'aria-required' attribute cause an error "This element has an unsupported ARIA attribute" in Google Chrome accessibility validator.
https://www.w3.org/TR/wai-aria/states_and_properties#aria-required
This addresses #1841.