Skip to content

Core: removed aria-required attribute #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2017
Merged

Core: removed aria-required attribute #2012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,6 @@ $.extend( $.fn, {
$.each( argument.split( /\s/ ), function( index, method ) {
filtered[ method ] = existingRules[ method ];
delete existingRules[ method ];
if ( method === "required" ) {
$( element ).removeAttr( "aria-required" );
}
} );
return filtered;
}
Expand All @@ -180,7 +177,6 @@ $.extend( $.fn, {
param = data.required;
delete data.required;
data = $.extend( { required: param }, data );
$( element ).attr( "aria-required", "true" );
}

// Make sure remote is at back
Expand Down Expand Up @@ -418,10 +414,6 @@ $.extend( $.validator, {
if ( this.settings.invalidHandler ) {
$( this.currentForm ).on( "invalid-form.validate", this.settings.invalidHandler );
}

// Add aria-required to any Static/Data/Class required fields before first validation
// Screen readers require this attribute to be present before the initial submission https://www.w3.org/TR/WCAG-TECHS/ARIA2.html
$( this.currentForm ).find( "[required], [data-rule-required], .required" ).attr( "aria-required", "true" );
},

// https://jqueryvalidation.org/Validator.form/
Expand Down
37 changes: 0 additions & 37 deletions test/aria.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,40 +44,3 @@ QUnit.test( "resetForm(): removes all aria-invalid attributes", function( assert
assert.equal( $( "#ariaInvalid [aria-invalid]" ).length, 0, "resetForm() should remove any aria-invalid attributes" );
} );

QUnit.test( "Static required field adds aria-required", function( assert ) {
var ariaRequiredStatic = $( "#ariaRequiredStatic" ),
form = $( "#ariaRequired" );

form.validate();
assert.equal( ariaRequiredStatic.attr( "aria-required" ), "true" );
} );

QUnit.test( "Data required field adds aria-required", function( assert ) {
var ariaRequiredData = $( "#ariaRequiredData" ),
form = $( "#ariaRequired" );

form.validate();
assert.equal( ariaRequiredData.attr( "aria-required" ), "true" );
} );

QUnit.test( "Class required field adds aria-required", function( assert ) {
var ariaRequiredClass = $( "#ariaRequiredClass" ),
form = $( "#ariaRequired" );

form.validate();
assert.equal( ariaRequiredClass.attr( "aria-required" ), "true" );
} );

QUnit.test( "Dynamically required field adds aria-required after valid()", function( assert ) {
var ariaRequiredDynamic = $( "#ariaRequiredDynamic" ),
form = $( "#ariaRequired" );

form.resetForm();
form.validate( {
rules: {
ariaRequiredDynamic: "required"
}
} );
ariaRequiredDynamic.valid();
assert.equal( ariaRequiredDynamic.attr( "aria-required" ), "true" );
} );
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy