Skip to content

Launcher: Defensive fixes #8730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Launcher: Defensive fixes #8730

wants to merge 6 commits into from

Conversation

mrnoname1000
Copy link
Contributor

@mrnoname1000 mrnoname1000 commented Mar 31, 2025 •
edited
Loading

Added some checks to the launcher to handle missing HOME, JAVA_HOME, or argument to -{C,e,I,S}

Fixes #8747

@mrnoname1000 mrnoname1000 requested a review from headius March 31, 2025 03:16
headius
headius reviewed Apr 1, 2025
View reviewed changes
Copy link
Member

@headius headius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to detect whether we found a JAVA_HOME a different way that works without the release file; perhaps $JAVA_HOME/bin/java?

@mrnoname1000
Copy link
Contributor Author

Added some code to parse $JAVA_HOME/release instead of source it, which lets us use $JAVA_RELEASE_VERSION for the AppCDS archive which may be more correct and will handle Graal better

@mrnoname1000
Copy link
Contributor Author

I think we need to detect whether we found a JAVA_HOME a different way that works without the release file; perhaps $JAVA_HOME/bin/java?

The problem with this is we find JAVA_HOME by trimming /bin/java from the path to java, if we add that back on it will always match

@mrnoname1000 mrnoname1000 mentioned this pull request Apr 16, 2025
Open
@headius headius mentioned this pull request Apr 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headius headius headius left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Launcher script chokes on GraalVM release file
2 participants
@mrnoname1000 @headius
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy