Tweaks to further improve startup speed and memory use #8831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resource.getInputStream always returns a LoadServiceResourceInputStream so constructing another is just a waste of time.
InputStream.readAllBytes was added in Java 9, and when possible it detects the exact size of the incoming file or stream and allocates only a single array to read all. This avoids the old logic that allocated n + 1 arrays based on the read chunk size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few tweaks based on some recent profiling of JRuby 10, both doing a simple hello world
jruby -e getsand spinning up JRuby instances in a tight loop.