Update actions version in docs #2318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After , https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ the current actions will fail otherwise.
There was a problem hiding this comment.
Hey @fmaussion It seems like you tried to modify versions on both HTML aritificat generation and Github Pages Deployment feature without doing the necessary testing. I woould recommend to create local testing procedures either on your local computer or usinng codespace. the testing procedure should include testing the build, testing the configuration and testing the utility functions
|
Jupyterbook itself uses the artifacts versions to build itself: https://github.com/jupyter-book/jupyter-book/pull/2317/files My change is solely for the docs, I don't think it can be tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions the current actions will fail otherwise.