feat(exec) Filter by tags in exec cmd #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Can you also add tests for this? I'm trying not to merge anything new without tests, and sometimes it's hard cause no foundation exists. Let me know if I can help you out with this if it's too much! |
|
the test for this function is already here: https://github.com/knqyf263/pet/blame/main/snippet/snippet_test.go#L307 |
|
Looked into this a bit more, and I want to e2e test the filtering functionality not just this one function, but it's taking some time. I think it's a slightly big refactor so not going to lay it on you 😄 My goal from adding these additional tests is just making sure the old functionality doesn't change with this change, but in an automated way. Sorry to keep you waiting! Will merge this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Reuse of the FilterByTags method and adding the ability to filter by tags, not just a single tag, when using the 'exec' command.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.