fix issue client-go #613 #129712

AWoelfel · 2025-01-20T14:40:01Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allows developers to use types.StrategicMergePatchType during unit tests within fake.FakeDynamicClient

Which issue(s) this PR fixes:

Fixes #613

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2025-01-20T14:40:05Z

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

linux-foundation-easycla · 2025-01-20T14:40:06Z

The committers listed above are authorized under a signed CLA.

✅ login: AWoelfel (b08e199, a0b5f5d)

k8s-ci-robot · 2025-01-20T14:40:11Z

Welcome @AWoelfel!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-01-20T14:40:12Z

Hi @AWoelfel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-01-20T14:40:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AWoelfel
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

staging/src/k8s.io/client-go/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cici37 · 2025-01-21T21:05:59Z

/triage accepted
/cc @yongruilin

yongruilin · 2025-01-22T05:22:07Z

/cc @liggitt there was a conversation regarding the fix in another closed PR #78630 (comment) do you think it is still worth an improvement?

yongruilin · 2025-01-22T05:43:30Z

staging/src/k8s.io/client-go/dynamic/fake/simple.go

+	return knownPatchMeta
+}
+
+func defaultGvrToListMapping(scheme *runtime.Scheme) map[schema.GroupVersionResource]string {


nit: defaultGVRToListMapping

yongruilin · 2025-01-22T06:04:07Z

staging/src/k8s.io/client-go/testing/fixture.go

+type SchemeWithPatchMeta interface {
+	PatchMeta(kind schema.GroupVersionKind) strategicpatch.LookupPatchMeta


Could you add comments for the exported interface and function?

Sure thing!

Went over the code and added comments for clarifivation.

k8s-triage-robot · 2025-04-22T11:26:26Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-05-22T11:30:53Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

yongruilin · 2025-05-22T17:29:21Z

/ok-to-test

k8s-ci-robot · 2025-05-22T18:40:38Z

@AWoelfel: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-apidiff-client-go	`b08e199`	link	false	`/test pull-kubernetes-apidiff-client-go`
pull-kubernetes-linter-hints	`b08e199`	link	false	`/test pull-kubernetes-linter-hints`
pull-kubernetes-verify	`b08e199`	link	true	`/test pull-kubernetes-verify`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2025

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 20, 2025

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 20, 2025

k8s-ci-robot requested review from apelisse and jpbetz January 20, 2025 14:40

k8s-ci-robot requested a review from yongruilin January 21, 2025 21:06

k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 21, 2025

yongruilin reviewed Jan 22, 2025

View reviewed changes

k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jan 22, 2025

AWoelfel force-pushed the client-go-613 branch from 68e4eb4 to 72b3f00 Compare January 22, 2025 10:03

k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jan 22, 2025

AWoelfel added 2 commits January 22, 2025 12:21

fix issue client-go kubernetes#613

a0b5f5d

added comments and renamed some elements for clarification

b08e199

AWoelfel force-pushed the client-go-613 branch from 72b3f00 to b08e199 Compare January 22, 2025 11:21

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2025

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 22, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix issue client-go #613 #129712

fix issue client-go #613 #129712

AWoelfel commented Jan 20, 2025

Uh oh!

k8s-ci-robot commented Jan 20, 2025

Uh oh!

linux-foundation-easycla bot commented Jan 20, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented Jan 20, 2025

Uh oh!

k8s-ci-robot commented Jan 20, 2025

Uh oh!

k8s-ci-robot commented Jan 20, 2025

Uh oh!

cici37 commented Jan 21, 2025

Uh oh!

yongruilin commented Jan 22, 2025

Uh oh!

yongruilin Jan 22, 2025

Uh oh!

yongruilin Jan 22, 2025

Uh oh!

AWoelfel Jan 22, 2025

Uh oh!

k8s-triage-robot commented Apr 22, 2025

Uh oh!

k8s-triage-robot commented May 22, 2025

Uh oh!

yongruilin commented May 22, 2025

Uh oh!

k8s-ci-robot commented May 22, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

		type SchemeWithPatchMeta interface {
		PatchMeta(kind schema.GroupVersionKind) strategicpatch.LookupPatchMeta

fix issue client-go #613 #129712

Are you sure you want to change the base?

fix issue client-go #613 #129712

Conversation

AWoelfel commented Jan 20, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Jan 20, 2025

Uh oh!

linux-foundation-easycla bot commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jan 20, 2025

Uh oh!

k8s-ci-robot commented Jan 20, 2025

Uh oh!

k8s-ci-robot commented Jan 20, 2025

Uh oh!

cici37 commented Jan 21, 2025

Uh oh!

yongruilin commented Jan 22, 2025

Uh oh!

yongruilin Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

yongruilin Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

AWoelfel Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented Apr 22, 2025

Uh oh!

k8s-triage-robot commented May 22, 2025

Uh oh!

yongruilin commented May 22, 2025

Uh oh!

k8s-ci-robot commented May 22, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

linux-foundation-easycla bot commented Jan 20, 2025 •

edited

Loading