[WIP] Eliminate conversion in authz CEL binding #131806
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: simoncampion The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @simoncampion. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -89,3 +99,18 @@ func (c *CELMatcher) Eval(ctx context.Context, r *authorizationv1.SubjectAccessR | |||
| // return ALL matchConditions evaluate to TRUE successfully without error | |||
| return true, nil | |||
| } | |||
|
|
|||
| func getSpecSchema(r *authorizationv1.SubjectAccessReview) (*spec.Schema, error) { | |||
There was a problem hiding this comment.
While this works in the sense of passing the unit tests, I don't think this is the correct way of obtaining the OpenAPI schema for the SubjectAccessReviewSpec. How is it done correctly?
| subjectAccessReview := tt.subjectAccessReview | ||
| subjectAccessReview.TypeMeta = metav1.TypeMeta{ | ||
| APIVersion: authorizationv1.SchemeGroupVersion.String(), | ||
| Kind: "SubjectAccessReview", |
There was a problem hiding this comment.
I failed to find a constant in the code base for the Kind name. Is there a way to avoid the string literal here?
|
/sig api-machinery |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Avoids conversion to unstructured objects when binding to CEL using the new reflective wrapper.
Which issue(s) this PR fixes:
Part of #131520
Special notes for your reviewer:
We need to pass the OpenAPI schema for a
SubjectAccessReviewSpecto the reflective wrapper. I struggled to find out how to retrieve this schema. While I found a way that passes the unit tests, it surely isn't the desired way---for instance, it violates import restrictions. I'd appreciate any guidance on the correct way to handle this.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: