Skip to content

fixed logs issue #19931 #20138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed logs issue #19931 #20138

wants to merge 1 commit into from

Conversation

mattisafur
Copy link

fixes #19931

when running:
$ minikube logs --file log.txt --last-start-only
or
$ minikube logs --file log.txt --audit

before:

  • outputs requested log to stdout
  • creates a blank log.txt file

after:

  • outputs requested log to file
  • no output to stdout

I'm pretty new to go, let me know if there's something I should change.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 20, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mattisafur / name: mattisafur (58aadf1)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 20, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @mattisafur!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @mattisafur. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 20, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@ComradeProgrammer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 22, 2024
@mattisafur
Copy link
Author

/retest

@mattisafur
Copy link
Author

Whenever one of the maintainers gets to looking at this (it's really not major, take you time :3), I basically replaced two if statements that return to a switch statement and changed a little the way outputting to a file is done. letting you know because the git diff looks kind of confusing

Just letting you know, with this change there's a function that is not anywhere anymore, logs.OutputOffline, it was only used for outputting the whole log to a file and seems kind of redundant. it's still in the code.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattisafur
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20138) |
+----------------+----------+---------------------+
| minikube start | 51.2s    | 53.4s               |
| enable ingress | 17.4s    | 15.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 18.5s 15.5s 15.1s 18.5s 19.5s
Times for minikube (PR 20138) ingress: 16.0s 15.0s 16.0s 15.0s 15.5s

Times for minikube start: 52.2s 50.6s 51.8s 51.5s 50.1s
Times for minikube (PR 20138) start: 55.5s 49.6s 52.9s 54.9s 54.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20138) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.4s               |
| enable ingress | 12.5s    | 12.6s               |
+----------------+----------+---------------------+

Times for minikube start: 20.5s 20.4s 20.7s 24.1s 25.1s
Times for minikube (PR 20138) start: 23.4s 20.2s 24.3s 20.6s 23.4s

Times for minikube ingress: 12.7s 12.3s 12.8s 12.3s 12.2s
Times for minikube (PR 20138) ingress: 12.8s 12.8s 12.3s 12.3s 12.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20138) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 21.2s               |
| enable ingress | 25.8s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 19.5s 24.1s 22.7s 22.9s 22.3s
Times for minikube (PR 20138) start: 23.0s 19.6s 22.0s 22.8s 18.8s

Times for minikube ingress: 22.8s 22.8s 37.7s 22.8s 22.8s
Times for minikube (PR 20138) ingress: 22.7s 22.8s 39.3s 22.8s 23.3s

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 7, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minikube logs not outputing to file when using --last-start-only
6 participants
@mattisafur @k8s-ci-robot @minikube-bot @ComradeProgrammer @minikube-pr-bot @k8s-triage-robot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy