Skip to content

Addon nvidia-device-plugin: Update nvidia/k8s-device-plugin image from v0.17.1 to v0.17.2 #20786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

Addon nvidia-device-plugin: Update nvidia/k8s-device-plugin image from v0.17.1 to v0.17.2 #20786

merged 1 commit into from
May 19, 2025

Conversation

minikube-bot
Copy link
Collaborator

The k8s-device-plugin project released a new k8s-device-plugin image

This PR was auto-generated by make update-nvidia-device-plugin-version using update-nvidia-device-plugin-version.yml CI Workflow.

@minikube-bot minikube-bot force-pushed the auto_bump_nvidia_device_plugin_version branch from cefb857 to 94f66f3 Compare May 19, 2025 10:01
@minikube-bot minikube-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 19, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 19, 2025
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20786) |
+----------------+----------+---------------------+
| minikube start | 48.8s    | 49.7s               |
| enable ingress | 15.6s    | 15.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 20786) start: 49.6s 50.8s 50.2s 49.9s 48.0s
Times for minikube start: 50.1s 47.9s 47.8s 47.9s 50.2s

Times for minikube ingress: 18.5s 15.0s 14.4s 15.0s 15.0s
Times for minikube (PR 20786) ingress: 14.5s 15.0s 15.9s 15.0s 14.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20786) |
+----------------+----------+---------------------+
| minikube start | 24.3s    | 23.3s               |
| enable ingress | 13.3s    | 13.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 13.8s 12.8s 13.8s 13.8s 12.3s
Times for minikube (PR 20786) ingress: 12.3s 13.3s 13.3s 13.3s 13.3s

Times for minikube start: 23.3s 23.3s 25.7s 25.8s 23.2s
Times for minikube (PR 20786) start: 22.4s 24.1s 25.3s 22.9s 21.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20786) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 23.3s               |
| enable ingress | 26.0s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube start: 23.8s 20.9s 21.6s 23.9s 21.0s
Times for minikube (PR 20786) start: 24.6s 20.5s 23.1s 23.8s 24.6s

Times for minikube ingress: 22.8s 38.8s 22.8s 22.8s 22.8s
Times for minikube (PR 20786) ingress: 23.8s 39.3s 22.8s 22.8s 22.8s

@medyagh
Copy link
Member

medyagh commented May 19, 2025

/lgtm

@medyagh medyagh merged commit 6b62b02 into kubernetes:master May 19, 2025
36 of 43 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, minikube-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@medyagh medyagh Awaiting requested review from medyagh

Assignees

@medyagh medyagh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@minikube-bot @k8s-ci-robot @minikube-pr-bot @medyagh
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy