Skip to content

Minimal changes needed for FitSNAP-ReaxFF #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 115 commits into
base: develop
Choose a base branch
from

Conversation

alphataubio
Copy link
Collaborator

@alphataubio alphataubio commented Apr 7, 2025

Summary

  • refactor set_reaxff_parameters() to python/lammps/reaxff.py instead of python/lammps/core.py
  • refactor lammps_set_reaxff_*_parameter() to src/REAXFF/reaxff_library.[h,cpp] instead of src/library.[h,cpp]
  • add target_charge option to fix acks2/reaxff(/kk) for non-zero charge
  • add fixedorigin option to src/compute_dipole.cpp
  • add src/EXTRA-COMPUTE/compute_quadrupole.[h,cpp]
  • add src/EXTRA-COMPUTE/compute_esp_grid.[h,cpp]
  • add src/KOKKOS/compute_esp_grid_kokkos.[h,cpp]
  • normalize REAXFF parameters r_pi -> r_p, r_pi_pi -> r_pp, r_pi2 -> r_pp, r_vdW -> r_vdw for consistency across REAXFF, OPENMP, KOKKOS, FitSNAP-ReaxFF
  • add tor_flag needed by FitSNAP-ReaxFF to optimize TOR wildcard / non-wildcard parameters
  • move gauss_exp parameter from external file to unused force field location (ATM row 2 column 5) for QTPIE optimization in FitSNAP-ReaxFF
  • move ~100 ReaxFF force fields to FitSNAP/reaxff/potentials
  • fix QTPIE unit test

Related Issue(s)

FitSNAP/FitSNAP#266

Author(s)

@alphataubio

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

Implementation Notes

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • Suitable tests have been added to the unittest tree.
  • A package specific README file has been included or updated
  • One or more example input decks are included

Further Information, Files, and Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy