Skip to content

Minimal changes needed for FitSNAP-ReaxFF #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 139 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
139 commits
Select commit Hold shift + click to select a range
493dd10
Create reaxff.py
alphataubio Jan 29, 2025
c9c37b5
Create reaxff_library.cpp
alphataubio Jan 29, 2025
d0552fc
Create reaxff_library.h
alphataubio Jan 29, 2025
990240d
Update reaxff_library.cpp
alphataubio Jan 29, 2025
b7e2a92
Update reaxff.py
alphataubio Jan 29, 2025
c381683
add kwargs
alphataubio Jan 29, 2025
92289ba
import ctypes
alphataubio Jan 29, 2025
5fdf9e5
Update reaxff.py
alphataubio Jan 29, 2025
da28e19
optimize by splitting defined parameters and changing values
alphataubio Jan 30, 2025
1e93d46
set GEN.bond_softness parameter
alphataubio Jan 30, 2025
2b3ead9
add GEN to reaxff python interface
alphataubio Jan 30, 2025
d91c73b
Update reaxff.py
alphataubio Jan 30, 2025
6c2e2e1
add ATM.gauss_exp for QTPIE
alphataubio Jan 30, 2025
a83be46
add lammps_set_reaxff_gen_parameter() and cleanup
alphataubio Jan 30, 2025
ac47eb3
make fix acks2 doc consistent with code and literature
alphataubio Jan 30, 2025
233d34c
oops
alphataubio Jan 31, 2025
a44b1e1
typo
alphataubio Jan 31, 2025
777de77
add read_sdf command needed by fitsnap-reaxff
alphataubio Jan 31, 2025
1f0b84f
add gauss_exp to ffield unused ATM line 2 pos 5
alphataubio Jan 31, 2025
6a6dece
remove gfile when params is reaxff
alphataubio Jan 31, 2025
4b0e814
handle params reaxff without gfile
alphataubio Jan 31, 2025
7a616c0
add gauss_exp
alphataubio Jan 31, 2025
1fc8235
extract gauss_exp
alphataubio Jan 31, 2025
9279204
add warning how to avoid error with gauss_exp
alphataubio Feb 1, 2025
2f0b1b7
add ExceptionCheck
alphataubio Feb 2, 2025
f0df310
move to DFT
alphataubio Feb 7, 2025
f7429e0
allow cnt=2 for eg. N-N-N
alphataubio Mar 25, 2025
86b33d4
Update reaxff_library.cpp
alphataubio Mar 27, 2025
ee08029
Update reaxff_library.cpp
alphataubio Mar 27, 2025
af3f17d
FitSNAP-ReaxFF needs tor_flag for wildcard TOR entries
alphataubio Mar 27, 2025
1654150
add target_charge option to fix acks2/reaxff
alphataubio Mar 27, 2025
156caed
BUGFIX target_charge
alphataubio Mar 28, 2025
9fe13d0
Update reaxff_library.cpp
alphataubio Mar 29, 2025
be429ad
Update reaxff.py
alphataubio Apr 4, 2025
213b116
normalize r_pi_pi and r_pi2 to r_pp for consistency
alphataubio Apr 5, 2025
80abf51
normalize r_pi to r_p for consistency
alphataubio Apr 5, 2025
f8faea2
normalize r_vdW to r_vdw for consistency
alphataubio Apr 5, 2025
416686b
add fixedorigin option to compute_dipole
alphataubio Apr 5, 2025
e2931c7
add compute_quadrupole to EXTRA-COMPUTE
alphataubio Apr 5, 2025
b8784f0
Merge branch 'develop' into alphataubio-fs2
alphataubio Apr 7, 2025
5cca4bb
fix whitespace and add author for target_charge option
alphataubio Apr 7, 2025
753f325
add author for target_charge option
alphataubio Apr 7, 2025
ee34d56
fix latex _
alphataubio Apr 7, 2025
80a6e7e
fix merge conflict
alphataubio Apr 7, 2025
b137fa5
normalize r_pi->r_p and r_pi_pi->r_pp for consistency
alphataubio Apr 7, 2025
dd5d104
normalize r_vdW->r_vdw for consistency
alphataubio Apr 7, 2025
47ce279
fix qtpie unit test
alphataubio Apr 7, 2025
46a5fc7
Merge branch 'develop' into alphataubio-fs2
alphataubio Apr 7, 2025
8bc8136
fix missing boxxlo boxlo boxhigh in library documentation
alphataubio Apr 8, 2025
24f8739
add ereaxff parameters p_xel2, ealpha, ebeta, p_xel1
alphataubio Apr 21, 2025
bbb34a7
add compute esp/grid/local (first draft)
alphataubio Apr 22, 2025
9821704
add ereaxff option with default 0
alphataubio Apr 22, 2025
176968f
add templated Delta_i^xel for ereaxff
alphataubio Apr 22, 2025
2f2d73a
Merge branch 'develop' into alphataubio-fs2
alphataubio Apr 22, 2025
933604b
whitespace
alphataubio Apr 22, 2025
93ede43
Merge branch 'alphataubio-fs2' of https://github.com/alphataubio/lamm…
alphataubio Apr 22, 2025
3cc3c3a
add ereaxff params
alphataubio Apr 22, 2025
687a4f8
Delete compute_esp_grid_local.h
alphataubio Apr 24, 2025
0e19ca2
Delete compute_esp_grid_local.cpp
alphataubio Apr 24, 2025
bf08ea1
move gauss_exp to ATM R3C3
alphataubio Apr 24, 2025
eb1d649
add compute esp/grid to EXTRA-COMPUTE
alphataubio Apr 24, 2025
ae9ea7d
fix charge neutrality type/fraction (approximate) -> type/ratio (exact)
alphataubio Apr 24, 2025
10cedf6
regenerate reaxff tests on linux to avoid random generator on macos
Apr 24, 2025
acb51ea
refactor pair_reaxff_kokkos into .hpp's
alphataubio Apr 24, 2025
965893e
Merge branch 'alphataubio-fs2' of https://github.com/alphataubio/lamm…
alphataubio Apr 24, 2025
c339dca
fix clash with -Minform=severe
alphataubio Apr 27, 2025
47a1215
skip cmath check when cross compiling cuda on host with NVHPC
alphataubio Apr 27, 2025
5dca151
add BUILD_EXTERNAL_KOKKOS_DIR
alphataubio Apr 27, 2025
48edb7b
acks2/kk rewrite (first draft)
alphataubio Apr 28, 2025
32ef74d
Update pair_reaxff_kokkos.h
alphataubio Apr 29, 2025
5bd6906
Update pair_reaxff_bondorder_kokkos.hpp
alphataubio Apr 29, 2025
bbbfcf7
Update fix_acks2_reaxff_kokkos.h
alphataubio Apr 29, 2025
b07680d
Update fix_acks2_reaxff_kokkos.h
alphataubio Apr 29, 2025
1a82a18
Update fix_acks2_reaxff_kokkos.cpp
alphataubio Apr 29, 2025
05fb266
Merge branch 'develop' into alphataubio-fs2
alphataubio Apr 29, 2025
2c00f8b
add kokkos-kernels
alphataubio May 3, 2025
9687e14
Update compute_esp_grid.h
alphataubio May 3, 2025
ffe217e
Update compute_esp_grid.cpp
alphataubio May 3, 2025
2f475aa
workaround to quickly reset box on one proc
alphataubio May 3, 2025
51bb44a
Update compute_esp_grid.cpp
alphataubio May 3, 2025
fc61015
Update pair_reaxff_init_kokkos.hpp
alphataubio May 4, 2025
4f3231e
sparse BSR mixed precision Schur CG (first draft)
alphataubio May 4, 2025
36028c6
Create compute_esp_grid.rst
alphataubio May 4, 2025
9b05a41
Update compute_esp_grid.cpp
alphataubio May 4, 2025
05cba4d
Merge branch 'develop' into alphataubio-fs2
alphataubio May 4, 2025
2d2a9a1
Merge branch 'alphataubio-fs2' of https://github.com/alphataubio/lamm…
alphataubio May 4, 2025
95b090d
whitespace
alphataubio May 4, 2025
3f3f77f
whitespace
alphataubio May 4, 2025
6299000
download kokkos-kernels if not built locally
alphataubio May 4, 2025
e44a6b4
Update compute_esp_grid.rst
alphataubio May 4, 2025
9d47f05
Update Commands_compute.rst
alphataubio May 4, 2025
c3d71fb
Update compute.rst
alphataubio May 4, 2025
9ccfb42
Update compute_esp_grid.rst
alphataubio May 5, 2025
2b4884a
Update compute_esp_grid.cpp
alphataubio May 5, 2025
801eece
Update compute_esp_grid.h
alphataubio May 5, 2025
195b058
Update pair_reaxff_init_kokkos.hpp
alphataubio May 5, 2025
70c45c6
Update pair_reaxff_kokkos.cpp
alphataubio May 5, 2025
50c0aa6
Update fix_qeq_reaxff.cpp
alphataubio May 5, 2025
0cd64f4
Update fix_acks2_reaxff_legacy_kokkos.h
alphataubio May 5, 2025
3436438
Update fix_acks2_reaxff_legacy_kokkos.cpp
alphataubio May 5, 2025
5170f19
Update KOKKOS.cmake
alphataubio May 5, 2025
a7f1ea5
Update compute_esp_grid.cpp
alphataubio May 6, 2025
dce180a
Update compute_esp_grid.h
alphataubio May 9, 2025
1abe957
Update compute_esp_grid.cpp
alphataubio May 9, 2025
2228080
fix DOWNLOAD_KOKKOS_KERNELS
alphataubio May 9, 2025
d381508
add compute esp/grid/kk
alphataubio May 9, 2025
5206da0
Update compute_esp_grid_kokkos.cpp
alphataubio May 10, 2025
c522a1a
disable all eti and only build BATCHED
alphataubio May 16, 2025
67ac817
extended lagrangian / mixed precision kokkos-kernels (first draft)
alphataubio May 18, 2025
d0ff854
rename spec/atom to species/atom
alphataubio May 19, 2025
9fe1184
Update pair_reaxff_kokkos.h
alphataubio May 19, 2025
d85fce2
Update fix_reaxff_species_kokkos.cpp
alphataubio May 19, 2025
c5221c3
add compute species/atom/kk
alphataubio May 19, 2025
91da053
Update fix_qeq_reaxff_kokkos.cpp
alphataubio May 21, 2025
fdbd79d
Update fix_qeq_reaxff_kokkos.h
alphataubio May 21, 2025
fc3f240
rename imax to maxiter for consistency with option name
alphataubio May 21, 2025
caa94d5
Delete fix_acks2_reaxff_legacy_kokkos.cpp
alphataubio May 21, 2025
b74dd09
Delete fix_acks2_reaxff_legacy_kokkos.h
alphataubio May 21, 2025
f0d2cd6
Update fix_acks2_reaxff_schur_kokkos.hpp
alphataubio May 21, 2025
28ce24f
rename imax to maxiter for consistency with option name
alphataubio May 21, 2025
8d5b71f
Update pair_reaxff_init_kokkos.hpp
alphataubio May 21, 2025
1c0c7bc
Update pair_reaxff_kokkos.cpp
alphataubio May 21, 2025
d4ef279
first compile no errors
alphataubio May 21, 2025
996e81d
refactor schur and comm to .hpp's
alphataubio May 21, 2025
83c1318
Update fix_qeq_reaxff_kokkos.h
alphataubio May 21, 2025
604c5a3
Update fix_qeq_reaxff_comm_kokkos.hpp
alphataubio May 21, 2025
885d1e2
Update KOKKOS.cmake
alphataubio May 21, 2025
7aae80e
Update fix_qeq_reaxff_schur_kokkos.hpp
alphataubio May 22, 2025
bec669d
Update fix_qeq_reaxff_kokkos.h
alphataubio May 22, 2025
ae2356a
Update fix_qeq_reaxff_kokkos.cpp
alphataubio May 22, 2025
319c00f
refactor with kokkos-kernels graph (first draft)
alphataubio May 24, 2025
5930759
Update fix_qeq_reaxff_schur_kokkos.hpp
alphataubio May 24, 2025
bd8b5b8
Update fix_qeq_reaxff_kokkos.cpp
alphataubio May 24, 2025
4a4076a
tmp debug revert later
alphataubio May 25, 2025
eb535a0
Update fix_qeq_reaxff_comm_kokkos.hpp
alphataubio May 25, 2025
ae5e774
Update fix_qeq_reaxff_kokkos.cpp
alphataubio May 25, 2025
27a3f61
Update fix_qeq_reaxff_kokkos.cpp
alphataubio May 25, 2025
504300d
Update fix_qeq_reaxff_kokkos.h
alphataubio May 25, 2025
4233c93
Update fix_qeq_reaxff_schur_kokkos.hpp
alphataubio May 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename spec/atom to species/atom
  • Loading branch information
alphataubio committed May 19, 2025
commit d0ff854e783f22e5dd098abb723c60f9fbe05829
8 changes: 4 additions & 4 deletions src/KOKKOS/fix_reaxff_species_kokkos.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ void FixReaxFFSpeciesKokkos::FindMolecule()
int change,done,anychange;
int *mask = atom->mask;
double bo_tmp,bo_cut;
double **spec_atom = f_SPECBOND->array_atom;
double **species_atom = f_SPECIESBOND->array_atom;

inum = reaxff->list->inum;
typename ArrayTypes<LMPHostType>::t_int_1d ilist;
Expand All @@ -84,9 +84,9 @@ void FixReaxFFSpeciesKokkos::FindMolecule()
i = ilist[ii];
if (mask[i] & groupbit) {
clusterID[i] = atom->tag[i];
x0[i].x = spec_atom[i][1];
x0[i].y = spec_atom[i][2];
x0[i].z = spec_atom[i][3];
x0[i].x = species_atom[i][1];
x0[i].y = species_atom[i][2];
x0[i].z = species_atom[i][3];
}
else clusterID[i] = 0.0;
}
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy