fix(client): scope mask function to resources singleton #1210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Refactors Langfuse client to centralize mask function management in
LangfuseResourceManager
for consistent span handling.Langfuse
client class toLangfuseResourceManager
singleton for centralized management.mask
parameter (type:MaskFunction
) toLangfuseResourceManager
class for resource-level control.Langfuse
class inclient.py
to useLangfuseResourceManager
for mask function.LangfuseSpanWrapper
inspan.py
to utilize the centralized mask function.test_core_sdk.py
andtest_otel.py
to reflect changes in mask function handling.This description was created by
for e66ef81. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Refactors the masking functionality in the Python client by moving mask function management from
Langfuse
class toLangfuseResourceManager
singleton for better resource handling and consistency.Langfuse
client class toLangfuseResourceManager
singleton for centralized managementmask
parameter (type:MaskFunction
) toLangfuseResourceManager
class for resource-level control