fix(resource-manager): do not register processor if tracing disabled #1215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
tracing_enabled
parameter to conditionally initialize tracing inLangfuseResourceManager
andLangfuse
client.tracing_enabled
parameter toLangfuseResourceManager
andLangfuse
constructor._initialize_instance()
inresource_manager.py
to conditionally initialize tracer and span processor based ontracing_enabled
.client.py
, passtracing_enabled
toLangfuseResourceManager
and useNoOpTracer
if tracing is disabled.LangfuseResourceManager.__new__()
to defaulttracing_enabled
toTrue
if not specified.This description was created by
for ae7ca32. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Optimizes the Langfuse client by conditionally initializing OpenTelemetry tracing based on configuration, preventing unnecessary processor registration when tracing is disabled.
tracing_enabled
parameter toLangfuseResourceManager
inlangfuse/_client/resource_manager.py
for conditional tracing initializationLangfuse
client inlangfuse/_client/client.py
to properly propagate tracing configuration