fix(client): use tracing_enabled in get_client #1220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes
tracing_enabled
propagation in Langfuse client initialization to ensure consistent tracing behavior across instances.tracing_enabled
inget_client()
inget_client.py
to ensure consistent tracing across client instances.tracing_enabled
as an instance variable in_initialize_instance()
inresource_manager.py
.tracing_enabled
assignment inresource_manager.py
.test_create_generation()
intest_core_sdk.py
to correct JSON string formatting.This description was created by
for 2d1cec6. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Fixes bug in client initialization where
tracing_enabled
flag wasn't properly propagated when creating new Langfuse client instances viaget_client()
. This ensures consistent tracing behavior across multiple clients.tracing_enabled
setting inlangfuse/_client/get_client.py
to maintain state across client instancestracing_enabled
as instance variable inlangfuse/_client/resource_manager.py
's_initialize_instance
method