fix(flushing): rely on OTEL default flush settings #1229
Merged
+9
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Modify
LangfuseSpanProcessor
to use OpenTelemetry's default flush settings when environment variables are not set.LangfuseSpanProcessor
inspan_processor.py
to use OpenTelemetry's default flush settings whenLANGFUSE_FLUSH_AT
andLANGFUSE_FLUSH_INTERVAL
are not set.flush_at
andflush_interval
are set toNone
if environment variables are not provided, allowing OpenTelemetry defaults to apply.This description was created by
for eace769. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Modifies flush settings handling in
langfuse/_client/span_processor.py
to better align with OpenTelemetry's default behavior, removing hardcoded fallback values.