Continue As New #245
Open
Continue As New #245
+174
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/States/WorkflowContinuedStatus.php | Adds new continued status class |
| src/Traits/Continues.php | Implements continueAsNew() logic and promise marker |
| src/Models/StoredWorkflow.php | Adds continuedWorkflows relation and root/active methods |
| src/Workflow.php | Handles ContinuedWorkflow in handle() |
| src/WorkflowStub.php | Routes calls to the active workflow instance |
| tests/Fixtures/TestContinueAsNewWorkflow.php | New fixture for continue-as-new workflow |
| tests/Feature/ContinueAsNewWorkflowTest.php | Feature test validating continue-as-new behavior |
| tests/Unit/States/WorkflowStatusTest.php | Updates state config test to include continued status |
| tests/TestCase.php | Registers failed queue table migration |
| tests/.env.unit, tests/.env.feature | Defines QUEUE_FAILED_DRIVER=null |
| .github/workflows/php.yml | Exports QUEUE_FAILED_DRIVER in CI and adds log artifact |
Comments suppressed due to low confidence (1)
.github/workflows/php.yml:78
- Quoting
"null"makes it a string in the CI environment. Remove the quotes so that the runner interprets it as a true null value.
QUEUE_FAILED_DRIVER: "null"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for “continue as new” workflows, updating core classes, model relations, and tests to enable workflows to restart with new input through a ContinuedWorkflow marker.