add resources nav-item to contain resources and videos as row #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leulad <leuladnew@gmail.com>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@leulad please switch to the column dropdown menu items as discussed in the call. |
assets/scss/_navbar_project.scss
Outdated
| @@ -61,6 +65,64 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| .nav-item-row{ | |||
There was a problem hiding this comment.
why arent' we using the existing sytles for these elements @leulad ?
There was a problem hiding this comment.
sorry I misunderstood row as the choice,
vishalvivekm
requested changes
May 19, 2025
Signed-off-by: leulad <leuladnew@gmail.com>
… into nav-resources-drop-row
… into nav-resources-drop-row
|
I have changed it to column, sorry I misunderstood, and reverted unnecessary changes |
….svg Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
vishalvivekm
approved these changes
May 19, 2025
|
@leulad apologies, but we want what you had previously, i.e. in row format, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #518
add resources dropdown in nav menu #518
Signed commits
Know Issues: