exersises #22
Open
exersises #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerevarsoul
reviewed
Feb 19, 2023
| @@ -3,7 +3,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
не нужно в репозиторий добавлять служебные файлы
| # ??? | ||
|
|
||
| print(f"{len(groups)} всего групп") | ||
| for index, group in enumerate(groups): |
There was a problem hiding this comment.
можно в enumerate через start указать номер с которого начинать
| @@ -12,8 +14,8 @@ | |||
| {'first_name': 'Маша'}, | |||
| {'first_name': 'Петя'}, | |||
| ] | |||
| # ??? | |||
|
|
|||
| for student in students: | |||
There was a problem hiding this comment.
Тут квадратичная сложность, потому что count будет весб список перебирать каждый раз. Лучше такого избегать
| @@ -26,8 +28,8 @@ | |||
| {'first_name': 'Маша'}, | |||
| {'first_name': 'Оля'}, | |||
| ] | |||
| # ??? | |||
|
|
|||
| duplicates = [x for i, x in enumerate(students) if i != students.index(x)] | |||
There was a problem hiding this comment.
аналогично, index это как еще один цикл. Итого цикл в цикле
| count_list = [] | ||
| for dic_student in s_class: | ||
| count_list.append(dic_student["first_name"]) | ||
| count_dic = Counter(count_list) |
There was a problem hiding this comment.
можно сразу в коунтер добавлять без промежточного списка
| # ??? | ||
|
|
||
| word_one = 'Архангельск' | ||
| glasniye = ["а", "я", "у", "ю", "о", "е", "ё", "э", "и", "ы"] |
There was a problem hiding this comment.
можно просто написать буквы слитно
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.