-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Implement king square highlights for end game states #17651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Here is a short video demonstrating the feature changes in action. In addition to what's shown in the video, we've tested all other endgame scenarios including stalemate, opponent disconnected, etc and confirm that all are working as expected. FeaturePreview.mp4Here is a longer video comparing the old version with the new one - https://youtu.be/4s-OVVlAaMA |
I meant that the information should appear via a small information bubble like for good/bad moves. Not via a flashing square. |
Okay, we will work on that. |
maybe can close #15385 |
Out of curiosity where have you found the SVGs? and which licenses are they under? |
We found them in https://www.svgrepo.com. |
Hey! Feature.Fix.mp4We really appreciated your previous feedback. Feel free to share any further thoughts or insights! |
@Bayuo321 It seems that there are some statuses missing that can happen, but they are without an icon. Like VariantEnd and Cheat (It might be interesting to have a fallback in case it happens and not a specific one) Can find status code here: |
Hi, thanks for pointing that out! Also, here is the new stalemate icon: New.Draw.mp4Thanks again for your feedback! |
My idea was to have some icon as a fallback in case this happens. |
- Implement findKingSquare in util.ts to locate king position from FEN - Ensure chessground reloads after game ends (ctrl.ts) - Differentiate highlights based on mate, timeout, resign or draw/stalemate (ground.ts) - Created new endgame state icons (public/images/icons) - Add SCSS pulsing animation with the SVG icons on king squares for enhanced visuals (_chessground.scss) Co-authored-by: Pedro Antunes <pedro.a.antunes@tecnico.ulisboa.pt>
- Updated endgame state icons - Replaced infinite pulsing animation with a subtle one-time pop effect - Added drop-shadow to king icons for improved visual emphasis Co-authored-by: Pedro Antunes <pedro.a.antunes@tecnico.ulisboa.pt>
Oh, okay. |
the draw/handshake idea is nice. i would show the king using standard check visuals (against the red gradient background) with a flag icon for resign, hourglass for flagged. there is no need to mark both kings unless there is no victor. bugle doesn't really fit checkmate, maybe crossed swords or a tombstone would be better. |
Co-authored-by: Pedro Antunes pedro.a.antunes@tecnico.ulisboa.pt
@Piti06