Skip to content

Use unique function and variable names for update-template-almalinux-kitten.sh #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

jandubois
Copy link
Member

All the update-template-* are sourced into update-template.sh, so they must all use unique names that don't conflict with each other.

The almalinux-kitten script was a copy of the almalinux script and reused the variable and function names.

Fixes #3558

…kitten.sh

All the update-template-* are sourced into update-template.sh, so they
must all use unique names that don't conflict with each other.

The almalinux-kitten script was a copy of the almalinux script and reused
the variable and function names.

Signed-off-by: Jan Dubois <jan.dubois@suse.com>
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone May 20, 2025
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit f1c5aba into lima-vm:master May 20, 2025
33 checks passed
@jandubois jandubois deleted the almalinux-kitten branch May 20, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make update-templates fails: ./hack/update-template-almalinux-kitten.sh: line 72: almalinux_jq_filter_directory: readonly variable
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy