Skip to content

[WIP] Update alpine image to 3.10 #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bjwschaap
Copy link

  • I started with updating tools/alpine/Dockerfile to use alpine:3.10 as base image.
  • Then had to update the packages file to remove obsolete, and include some new packages.
  • Also updated containerd and iucode to the latest release versions.
  • Proceeded, and succeeded to build this image locally.
  • Fixed the Dockerfile since with the new Go version, you need to use go vet
  • Fixed the location/package name of golint as well
  • Updated all references to the alpine image within the project to the (temporary) hash in order to test
  • did a make on tools
  • did a make on linuxkit

Since this is my first PR for Docker / linuxkit, I would welcome any guidance in getting this PR up to the required standards. I've read contribution guidelines, and tried to follow as good as possible.

@GordonTheTurtle
Copy link
Collaborator

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "update_alpine_3_10" git@github.com:bjwschaap/linuxkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Bastiaan Schaap <bastiaan.schaap@nedap.com>
Signed-off-by: Bastiaan Schaap <bastiaan.schaap@siteminds.nl>
@rn
Copy link
Member

rn commented Dec 19, 2019

I'm closing this since this is really a task which has to be done by a maintainer. It's a multi-step effort and each requires signing keys for the packages

@rn rn closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy