[labs/analyzer] Enforce POSIX path separators (#4890) #4902
Conversation
Using the regular `path` module would add backslashes to constructed paths on Windows.
🦋 Changeset detectedLatest commit: 0b3514f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@ClaudioHoffmann thanks a lot! We'll need the Google CLA signed to proceed. |
|
It would be really great to have a test here to make sure we don't regress. I'm surprised we didn't have a failing test on Windows already. We only run a subset of test on Windows runners, so many we didn't run an existing test that would cover this. |
|
Signed the CLA, and will add a test later. |
|
@ClaudioHoffmann are you still planning on adding a test? |
|
Doesn't look like it, we're short on budget and this test framework is too multi-layered and sluggish for me to figure out within that. |
|
@ClaudioHoffmann fair enough. Thanks for the initial PR! I'll try to add a test and merge soon. |
Fixes #4890.