Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Fix tests #5790

Merged
merged 9 commits into from
Jul 21, 2023
Merged

[v3] Fix tests #5790

merged 9 commits into from
Jul 21, 2023

Conversation

nuernbergerA
Copy link
Contributor

@nuernbergerA nuernbergerA commented Jul 20, 2023

Fix failing test due to L9/10 validation changes
Fixed also the turolinks test
and a bug with the legacy support for queryString

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livewire ❌ Failed (Inspect) Jul 20, 2023 8:55pm

@nuernbergerA nuernbergerA changed the title [v3] Fix unit tests - support L9 and L10 validation messages [v3] Fix tests Jul 20, 2023
@joshhanley
Copy link
Member

Had a look at the last failing test LegacyTests\Browser\Redirects\Test::it_correctly_shows_flash_messages_before_and_after_direct test and the reason it is failing is because it's not doing a full page refresh.

Navigate is taking control and redirecting it internally for some reason. The alpine:navigated event is firing, so isNavigating is being set to true in the below snippet, hence navigate is handling the redirect. Not sure yet why that event is being fired.

https://github.com/livewire/livewire/blob/master/js/features/supportNavigate.js#L5-L6

@joshhanley
Copy link
Member

Looking at the stack trace, it seems there is a setTimeout(() => fireEventForOtherLibariesToHookInto()) that is being run when the navigate plugin is being initialised. But I can't find that code anywhere.

image

@nuernbergerA
Copy link
Contributor Author

nuernbergerA commented Jul 21, 2023

@joshhanley i assume the dist js files are build from some local source, because history & navigate are not published on npm
and livewire3 branch on alpinejs is 2 weeks old

image

@joshhanley joshhanley merged commit 2e42946 into livewire:master Jul 21, 2023
@joshhanley
Copy link
Member

Thanks!

@nuernbergerA nuernbergerA deleted the fix-unit-test branch July 21, 2023 21:36
@lonnylot lonnylot mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy