Skip to content

Fix form properties fill from URL #9318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robert-stanciu
Copy link
Contributor

Review the contribution guide first at: https://livewire.laravel.com/docs/contribution-guide

1️⃣ Is this something that is wanted/needed? Did you create a discussion about it first?

2️⃣ Did you create a branch for your fix/feature? (Main branch PR's will be closed)

3️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.

4️⃣ Does it include tests? (Required)

5️⃣ Please include a thorough description (including small code snippets if possible) of the improvement and reasons why it's useful.

Thanks for contributing! 🙌

@robert-stanciu
Copy link
Contributor Author

Hello @calebporzio, could you take a look?

@lrljoe
Copy link
Contributor

lrljoe commented May 22, 2025

Would recommend not using fill in this approach.

Generically, to my mind, your Form is your reusable create/update interface. It is how you map your frontend forms, against your component/backend logic.

Developers should map querystring against a form object themselves via the Component, rather than the Form.
Your approach also potentially has complexities/conflicts where there are several components on a page, each with Forms, naming conflicts etc.

Keeping querystring logic in the Component keeps it consistent, and simple.

Otherwise this is potentially a slippery slope, if Component level features start being added to the Form, then it defeats the purpose of the Form being a lightweight way to reuse frontend/backend interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy